Skip to content

Conversation

@lukzhang
Copy link
Contributor

@lukzhang lukzhang commented Nov 8, 2025

Closes #367

This PR implements support for the credentialSpecs parameter in the container definition, which is required for Windows gMSA tasks on ECS.

Includes:

  • Variable passthrough in container-definition and service modules.
  • Documentation updates.
  • A new example (examples/windows-gmsa-service) to demonstrate usage.

@bryantbiggs bryantbiggs changed the title feat(container): Add support for credentialSpecs to enable Windows gMSA feat: Add support for credentialSpecs on container definition to enable Windows gMSA Nov 8, 2025
@bryantbiggs
Copy link
Member

just run pre-commit run -a and it will make it pass CI

@lukzhang
Copy link
Contributor Author

just run pre-commit run -a and it will make it pass CI

Ok thanks, will give it another try

@bryantbiggs bryantbiggs merged commit 654d7d2 into terraform-aws-modules:master Nov 13, 2025
12 checks passed
antonbabenko pushed a commit that referenced this pull request Nov 13, 2025
## [6.8.0](v6.7.0...v6.8.0) (2025-11-13)

### Features

* Add support for `credentialSpecs` on container definition to enable Windows gMSA ([#368](#368)) ([654d7d2](654d7d2))
@antonbabenko
Copy link
Member

This PR is included in version 6.8.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

container definition needs to recognize credentialSpecs

3 participants